Infra: Gradle init #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
previously approved these changes
Jan 2, 2023
| # https://help.github.com/articles/dealing-with-line-endings/ | ||
| # | ||
| # Linux start script should use lf | ||
| /gradlew text eol=lf |
There was a problem hiding this comment.
nit: wouldnt this be the default?
There was a problem hiding this comment.
Auto-generated by gradle init
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip | ||
| networkTimeout=10000 | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
There was a problem hiding this comment.
in other nessie repos we seem to:
a) also commit wrapper.jar https://github.com/projectnessie/nessie/tree/main/gradle/wrapper
b) also set distributionSha256Sum https://github.com/projectnessie/nessie/blob/main/gradle/wrapper/gradle-wrapper.properties
There was a problem hiding this comment.
done. Good observation.
build.gradle.kts
Outdated
| @@ -0,0 +1,15 @@ | |||
| /* | |||
| * Copyright (C) 2022 Dremio | |||
There was a problem hiding this comment.
oh yeah. Happy new year ;)
XN137
previously approved these changes
Jan 2, 2023
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-all.zip | ||
| networkTimeout=10000 | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
XN137
approved these changes
Jan 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle initpre-requisite for #2