Catalog/S3: Allow custom trust and key stores #9012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
reviewed
Jul 4, 2024
catalog/files/impl/src/main/java/org/projectnessie/catalog/files/s3/S3Config.java
Outdated
Show resolved
Hide resolved
dimas-b
reviewed
Jul 4, 2024
catalog/files/impl/src/main/java/org/projectnessie/catalog/files/s3/S3Config.java
Outdated
Show resolved
Hide resolved
dimas-b
previously approved these changes
Jul 4, 2024
…es/s3/S3Config.java Co-authored-by: Dmitri Bourlatchkov <[email protected]>
…es/s3/S3Config.java Co-authored-by: Dmitri Bourlatchkov <[email protected]>
adutra
reviewed
Jul 5, 2024
| * nessie.catalog.service.s3.trust-store.password} must be supplied as well when providing a | ||
| * custom trust store. | ||
| * | ||
| * <p>When running in k8s or Docker, the path is local within the pod/container and must be |
There was a problem hiding this comment.
Should I go ahead an implement support for this in the Helm chart?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8834