-
Notifications
You must be signed in to change notification settings - Fork 30
feat: Azure multi-cloud deployment with reorganized structure #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Azure multi-cloud deployment with reorganized structure #16
Conversation
Azure deployment features: - Single agent deployment script for Azure VMs - Multi-agent deployment with supervisor management (multiple agents per VM) - Multi-region deployment across Azure regions - Base64-encoded API keys for security - Quota checking and public IP reuse support - Clean cloud-init YAML generation with Python templating Project reorganization: - Moved AWS scripts into scripts/aws/ directory - Moved Azure scripts into scripts/azure/ directory - Updated all READMEs with multi-cloud documentation - Updated .gitignore for cloud-init temp files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces comprehensive Azure deployment capabilities for NANDA agents alongside a significant project reorganization to support multi-cloud deployments. The changes enable deploying agents on Azure VMs with the same feature parity as existing AWS and GCP deployments, while reorganizing all cloud-specific scripts into dedicated platform directories for better maintainability.
Key changes:
- Added three Azure deployment scripts supporting single-agent, multi-agent, and multi-region deployments
- Reorganized AWS and GCP scripts into platform-specific subdirectories (
scripts/aws/,scripts/gcp/) - Updated all documentation to reflect multi-cloud architecture and provide platform-specific guidance
Reviewed Changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/azure/single-agent-deployment.sh | New Azure single-agent deployment script with cloud-init configuration and NSG setup |
| scripts/azure/multi-agent-deployment.sh | New Azure multi-agent deployment using supervisor management with base64-encoded setup scripts |
| scripts/azure/multi-region-deployment.sh | New Azure multi-region orchestration script for geographic distribution |
| scripts/azure/README.md | Comprehensive Azure deployment documentation with prerequisites, examples, and troubleshooting |
| scripts/aws/README.md | New AWS-specific documentation moved from main scripts directory |
| scripts/README.md | Updated to document multi-cloud support with platform comparison table |
| README.md | Updated quick start examples to reflect reorganized multi-cloud structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Things to improve: API key security: ANTHROPIC_API_KEY is passed as a positional arg and written directly into cloud-init. Recommend supporting environment variables to avoid secrets appearing in shell history and process lists. Firewall exposure: NSG rules allow traffic from all sources. Consider allowing configurable or restricted CIDRs. Resilience: Agent is run with nohup and won’t auto-restart. Not blocking, but worth documenting. Overall, this script is well-implemented and fits cleanly into the multi-cloud structure. |
Azure deployment features:
Project reorganization: