[kube-prometheus-stack] add flexibility to the cluster variable #6420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willianpaixao
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks,
jkroepke and
scottrigby
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Node Exporter / Nodes Grafana dashboard by adding support for the "All" option in the cluster variable dropdown and updating all PromQL queries to use regex matching. This aligns the dashboard with other dashboards in the repository and enables better flexibility for multi-cluster and single-cluster environments.
- Adds
includeAll: trueto the cluster variable definition to enable selection of all clusters - Updates all PromQL queries from exact matching (
cluster="$cluster") to regex matching (cluster=~"$cluster") - Updates the instance variable query to use regex matching for cluster filtering
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/kube-prometheus-stack/Chart.yaml | Bumps chart version from 80.4.1 to 80.4.2 |
| charts/kube-prometheus-stack/templates/grafana/dashboards-1.14/nodes.yaml | Adds includeAll option and updates all queries to use regex matching for cluster variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e nodes dashboard - Some metrics may not have a cluster label - Users want to view metrics across all clusters - Multi-cluster setups with optional cluster labeling Changes: - Update cluster variable to use regex matching and support "All" option - Modify all PromQL queries to use regex matching (=~) instead of exact matching (=) for the cluster label This enables the dashboard to work in environments where the cluster label may be missing or when users want to aggregate data across all clusters. Signed-off-by: Willian Paixao <[email protected]>
willianpaixao
force-pushed
the
feat/nodes-dashboard-flexible-cluster
branch
from
b505c72 to
84af2cf
Compare
jkroepke
requested changes
Dec 22, 2025
charts/kube-prometheus-stack/templates/grafana/dashboards-1.14/nodes.yaml
Show resolved
Hide resolved
Author
|
Hi @jkroepke, I had not seen that comment. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds flexibility to the cluster variable in the Node Exporter / Nodes Grafana dashboard to support environments where:
The changes enable the dashboard to work seamlessly in environments where the cluster label may be missing or when users want to aggregate data across all clusters.
Changes made:
includeAll: trueto the cluster variable configuration to enable an "All" optioncluster=~"$cluster") instead of exact matching (cluster="$cluster")This is particularly useful for single-cluster environments where the cluster label might not be set on node-exporter metrics, or for users who want to view aggregated metrics across multiple clusters.
Which issue this PR fixes
Special notes for your reviewer
The changes are minimal and focused only on the Nodes dashboard template. All PromQL queries have been updated consistently to use regex matching. The
allValue: ".*"was already present in the template, so this PR only adds theincludeAll: trueproperty to enable the UI option and updates the query operators.Checklist
[kube-prometheus-stack])