[kube-prometheus-stack] Add admission webhook PromQL options#6945
Merged
jkroepke merged 2 commits intoMay 27, 2026
Merged
Conversation
Signed-off-by: David Brusius <brusiusdavid@gmail.com>
jkroepke
approved these changes
May 27, 2026
Member
|
Thanks |
3 tasks
1 task
This was referenced May 27, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds
prometheusOperator.admissionWebhooks.deployment.promqlOptionstokube-prometheus-stackand renders it as the--promql-optionsargument on the separate prometheus-operator admission webhook deployment.This lets users enable PromQL parser options for webhook validation of
PrometheusRuleresources, e.g.extended-range-selectors, matching the admission webhook CLI support added in prometheus-operator v0.91.0.Example:
Which issue this PR fixes
N/A
Special notes for your reviewer
promqlOptionsdefaults to an empty list. When set, it requires theprometheus-operator/admission-webhookimage to be v0.91.0 or newer.Local validation run:
helm dependency build charts/kube-prometheus-stackhelm lint charts/kube-prometheus-stackhelm unittest --strict --file 'unittests/**/*.yaml' charts/kube-prometheus-stackhelm template ...confirmed--promql-options=extended-range-selectors,experimental-functionsis renderedChecklist
[prometheus-couchdb-exporter])