Add "ignore_missing_values" option to metrics. - #301
Closed
AlexanderBeyn wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Alexander Beyn <malex@fatelectrons.org>
Contributor
|
Thanks, this needs a rebase to handle the new logging interface. |
Contributor
|
Hi, any update on this PR? It would be useful to have. |
jessicaxiejw
added a commit
to jessicaxiejw/json_exporter
that referenced
this pull request
Jan 5, 2026
jessicaxiejw
added a commit
to jessicaxiejw/json_exporter
that referenced
this pull request
Jan 5, 2026
Signed-off-by: Jessica Xie <jessicaxie@cohere.com>
Contributor
|
I created a new PR with the logs fix: #414 |
SuperQ
pushed a commit
that referenced
this pull request
Mar 28, 2026
* copy #301 Signed-off-by: Jessica Xie <jessicaxie@cohere.com> * fix log Signed-off-by: Jessica Xie <jessicaxie@cohere.com> * rename to allow_missing_key Signed-off-by: Jessica Xie <jessicaxie@cohere.com> --------- Signed-off-by: Jessica Xie <jessicaxie@cohere.com>
|
Closing since #414 got merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pulling metrics from a device that doesn't include them if they aren't valid in the current state. json_exporter doesn't output the specific missing metrics in such cases, but does show error messages. I couldn't find a way to mark metrics as optional, so I added an "ignore_missing_values" flag that stops the errors if a path is missing.