Add "ignore_missing_values" option to metrics. - #414
Merged
SuperQ merged 3 commits intoMar 28, 2026
Merged
Conversation
Signed-off-by: Jessica Xie <jessicaxie@cohere.com>
jessicaxiejw
force-pushed
the
jxie/feature_ignore_missing_values
branch
from
January 5, 2026 17:53
e9d79f1 to
127ca85
Compare
jessicaxiejw
force-pushed
the
jxie/feature_ignore_missing_values
branch
from
January 5, 2026 17:54
127ca85 to
97a8180
Compare
Contributor
Author
|
@SuperQ Could you take a look at the PR? |
SuperQ
requested changes
Feb 27, 2026
SuperQ
left a comment
SuperQ
left a comment
Contributor
There was a problem hiding this comment.
The json param for this is AllowMissingKeys. I think we should name this same. "Ignore missing values would be something like .key: missing_value.
So the feature config should be allow_missing_keys.
Contributor
Author
|
@SuperQ I renamed it from |
Signed-off-by: Jessica Xie <jessicaxie@cohere.com>
jessicaxiejw
force-pushed
the
jxie/feature_ignore_missing_values
branch
from
March 2, 2026 14:36
88c1ed3 to
40c0e84
Compare
Contributor
|
@SuperQ any chance to merge this? It will make the exporter a lot more flexible. |
Contributor
Author
|
Sorry, I rarely contribute to OSS project. How do I merge this? There is no merge button. 
|
Contributor
|
Sorry, was busy at a conference this week. Can merge now. |
Merged
eenchevlp
added a commit
to eenchevlp/json_exporter
that referenced
this pull request
Aug 12, 2026
* [FEATURE] Add allow_missing_key option to metrics prometheus-community#414 * [CHANGE] Update yaml library to go.yaml.in/yaml/v2 prometheus-community#437 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Evgeni Enchev <eenchev@liveperson.com>
ArthurSens
pushed a commit
that referenced
this pull request
Aug 13, 2026
* Release v0.8.0 * [FEATURE] Add allow_missing_key option to metrics #414 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Evgeni Enchev <eenchev@liveperson.com> * Remove non-user-facing yaml library update from CHANGELOG Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Evgeni Enchev <eenchev@liveperson.com> --------- Signed-off-by: Evgeni Enchev <eenchev@liveperson.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from #301 and with logging fixed
The original PR was created more than two years ago and appears to be abandoned.
cc @AlexanderBeyn