Add arm64 to DOCKER_ARCHS for multi-arch image builds - #368
Open
sulaimantok wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sulaiman Al farisi <23329919+sulaimantok@users.noreply.github.com>
TheMeier
approved these changes
Jul 21, 2026
|
My team ran into this and pushed this as well: Would love to get traction on this or the other, regardless. |
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The published Docker image on Docker Hub is currently
amd64-only, even thoughpromualready successfully cross-compiles the binary forlinux/arm64.This PR simply adds
arm64toDOCKER_ARCHSin the Makefile so that the published multi-arch Docker image includes it. This will allow the exporter to run natively on ARM64 nodes (such as Ampere Altra or Raspberry Pi clusters) without relying on slow QEMU emulation or failing withexec format error.Testing done
promu crossbuildand successfully built the image natively on an ARM64 host.docker inspect.smartctl_exporterbinary starts and runs correctly inside the ARM64 container.