Add Seagate FARM log metrics support - #376
Open
mpyne1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: mpyne <mpyne@45drives.com>
robbat2
approved these changes
Aug 16, 2026
k0ste
reviewed
Aug 18, 2026
| ).Default("standby").String() | ||
| smartctlFarmLog = kingpin.Flag("smartctl.farm-log", | ||
| "Collect Seagate FARM log metrics (requires smartmontools 7.4+)", | ||
| ).Default("false").Bool() |
Contributor
There was a problem hiding this comment.
Why default is false? This feature will broke something if will be enabled by default?
k0ste
reviewed
Aug 21, 2026
|
|
||
| var wg sync.WaitGroup | ||
| // Limit concurrent smartctl calls to avoid overwhelming the system | ||
| sem := make(chan struct{}, 8) |
Contributor
There was a problem hiding this comment.
Seems some hardcoded limits, not FARM related at all 🤷♂️
What is overwhelming you experienced? We specially merged #204 to avoid non-parallel timeouts on hosts with 60+ SATA devices. 18 month in prod on fleet with 30000 devices - no single issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Seagate FARM (Field Accessible Reliability Metrics) log support to smartctl_exporter.
FARM Log Metrics
Parses Seagate FARM log data from smartctl -j --log=farm and exposes the following Prometheus metric families:
FARM log collection is enabled via the --smartctl.farm-log flag and handles errors gracefully with limited concurrency to avoid overloading storage controllers.