Draft
iis: fix collector panic on application pool names containing '#'#2473
Conversation
Co-authored-by: jkroepke <1560587+jkroepke@users.noreply.github.com>
Co-authored-by: jkroepke <1560587+jkroepke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix IIS collector panic from special characters in application names
iis: fix collector panic on application pool names containing '#'
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deduplicateIISNamespanicked withslice bounds out of rangewhenever any IIS application pool name contained a#character, because the function assumed#only appears as a perflib counter suffix (Site_B#2).Bugs fixed
In
deduplicateIISNames(iis.go):strings.Split(name, "#")[0]misidentified"App#Pool"as a duplicate of"App"— replaced withiisCounterBaseName()that validates the suffix is purely numeric viastrconv.Atoiif/else: code that should record a new entry was instead writing tooriginalIndex(zero value0), corrupting the first elementslices.Delete(counterValues, index, 1)used1as the end index rather thanindex+1, causing the panic[]T"Site_B#9"incorrectly superseded"Site_B#10"; algorithm now tracks the winning numeric suffix with integer comparisonIn
iis_w3svc_w3wp.go:strings.Contains(name, "#")skipped metrics for any pool whose name legitimately contains#; replaced withiisCounterBaseName()stripping so only real perflib numeric suffixes are normalisedNew helper
All five callers updated to assign the returned slice. Unit tests added for both
iisCounterBaseNameanddeduplicateIISNames.