Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefix with _ if name begins with a number #1657

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

prefix with _ if name begins with a number #1657

wants to merge 4 commits into from

Conversation

shubhindia
Copy link

No description provided.

SuperQ
SuperQ reviewed Mar 11, 2025
View reviewed changes
SuperQ
SuperQ requested changes Mar 12, 2025
View reviewed changes
@SuperQ SuperQ requested a review from thomaspeitz March 12, 2025 09:42
@SuperQ
Copy link
Contributor

SuperQ commented Mar 12, 2025

It would be useful to add tests for this.

@shubhindia
Add a test for '_' prefix
7595933 
Signed-off-by: shubhindia <[email protected]>
cristiangreco
cristiangreco requested changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@cristiangreco cristiangreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe what is the use case here? Metric names are normally prefixed by aws_<namespace>_ by yace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiangreco cristiangreco cristiangreco requested changes

@SuperQ SuperQ SuperQ approved these changes

@thomaspeitz thomaspeitz Awaiting requested review from thomaspeitz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhindia @SuperQ @cristiangreco