Skip to content

chore: add xBSD pipelines #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
discordianfish merged 4 commits into from
Feb 4, 2025
Merged

chore: add xBSD pipelines #3160

discordianfish merged 4 commits into from
Feb 4, 2025

Conversation

@rexagod
Copy link
Contributor

@rexagod rexagod commented Oct 19, 2024 •
edited
Loading

Run tests on the following GOOS, in addition to Linux:

  • OpenBSD
  • FreeBSD
  • NetBSD
  • Dragonfly
  • Solaris
  • Darwin

The patch also makes changes to the testing scripts and introduces a tools binary to facilitate accommodating for various GOOS OOTB.

Fixes #2883.

@rexagod rexagod changed the title chore: add BSD pipeline [WIP] chore: add BSD pipeline Oct 19, 2024
@rexagod rexagod force-pushed the bsd-pipeline branch 19 times, most recently from 8ce2847 to f2e7601 Compare October 20, 2024 00:00
@discordianfish
Copy link
Member

discordianfish commented Oct 30, 2024

tests fail

@rexagod rexagod force-pushed the bsd-pipeline branch 9 times, most recently from 6c6bb6c to 17a424d Compare November 23, 2024 04:12
@rexagod rexagod force-pushed the bsd-pipeline branch 10 times, most recently from 9edc87b to c265b6d Compare December 22, 2024 07:57
@rexagod
fixup! chore: add xBSD pipelines
9b8328c 
Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod
Copy link
Contributor Author

rexagod commented Dec 22, 2024 •
edited
Loading

Good for reviews. I've also added Solaris and Darwin. I believe this completes support for all BSD platforms we target in this repository.

cc @discordianfish @SuperQ

discordianfish
discordianfish reviewed Dec 23, 2024
View reviewed changes
@discordianfish
Copy link
Member

discordianfish commented Dec 23, 2024

Beside that, this looks really great!

@rexagod
Copy link
Contributor Author

rexagod commented Dec 25, 2024

Dropped the changes for Makefile.common from this PR, so that we are not blocked by upstream. Also, this change is not required by GitHub's MacOS runners, so it's safe to merge this PR without that (all checks passing).

I'll pull the changes from upstream once they are merged there, but we can safely proceed independent of them.

@rexagod
Copy link
Contributor Author

rexagod commented Feb 4, 2025

Ping.

@discordianfish discordianfish merged commit 5340ad6 into prometheus:master Feb 4, 2025
13 checks passed
@discordianfish
Copy link
Member

discordianfish commented Feb 4, 2025

Going to merge but @SuperQ please still take a look to be aware etc

@SuperQ
Copy link
Member

SuperQ commented Feb 15, 2025

Hey folks, would you please cleanup the git history before merging changes? Or use the GitHub "squash and merge" function when merging?

It's not great when looking at git changes and seeing a bunch of "fixup fixup fixup" commits. It makes following feature changes difficult (git blame, git show, etc).

@SuperQ SuperQ mentioned this pull request Feb 15, 2025
Closed
@discordianfish
Copy link
Member

discordianfish commented Feb 17, 2025

I did a squash merg for forgot to edit the commit message. Sorry about that.

mikelolasagasti added a commit to mikelolasagasti/node_exporter that referenced this pull request Feb 19, 2025
@mikelolasagasti
build(deps): remove leftover from prometheus#3160
c5e21c7 
Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
SuperQ pushed a commit that referenced this pull request Feb 19, 2025
@mikelolasagasti
build(deps): remove leftover from #3160 (#3255)
7c69600 
Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
IbraAoad pushed a commit to IbraAoad/node_exporter that referenced this pull request Feb 20, 2025
@mikelolasagasti @IbraAoad
build(deps): remove leftover from prometheus#3160 (prometheus#3255)
31c1a20 
Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
Signed-off-by: IbraAoad <[email protected]>
IbraAoad pushed a commit to IbraAoad/node_exporter that referenced this pull request Feb 20, 2025
@mikelolasagasti @IbraAoad
build(deps): remove leftover from prometheus#3160 (prometheus#3255)
200c72e 
Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
Signed-off-by: IbraAoad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@discordianfish discordianfish discordianfish left review comments

Assignees

@SuperQ SuperQ

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build new *BSD CI pipelines

3 participants

@rexagod @discordianfish @SuperQ