chore: enable revive linter

Signed-off-by: Matthieu MOREL <[email protected]>

.golangci.yml

@@ -12,6 +12,7 @@ linters:
     - goimports
     - gomodguard
     - misspell
+    - revive
     - whitespace
 
 linters-settings:
@@ -24,6 +25,50 @@ linters-settings:
             recommendations:
               - errors
               - fmt
+  revive:
+    rules:
+      # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md
+      - name: blank-imports
+        disabled: true
+      - name: comment-spacings
+      - name: context-as-argument
+        arguments:
+          # Allow functions with test or bench signatures.
+          - allowTypesBefore: "*testing.T,testing.TB"
+      - name: context-keys-type
+      - name: dot-imports
+      - name: early-return
+        arguments:
+          - "preserveScope"
+      # A lot of false positives: incorrectly identifies channel draining as "empty code block".
+      # See https://github.com/mgechev/revive/issues/386
+      - name: empty-block
+        disabled: true
+      - name: error-naming
+      - name: error-return
+      - name: error-strings
+      - name: errorf
+      - name: exported
+      - name: increment-decrement
+      - name: indent-error-flow
+        arguments:
+          - "preserveScope"
+      - name: package-comments
+        # TODO(beorn7): Currently, we have a lot of missing package doc comments. Maybe we should have them.
+        disabled: true
+      - name: range
+      - name: receiver-naming
+      - name: redefines-builtin-id
+      - name: superfluous-else
+        arguments:
+          - "preserveScope"
+      - name: time-naming
+      - name: unexported-return
+      - name: unreachable-code
+      - name: unused-parameter
+      - name: var-declaration
+      - name: var-naming
+        disabled: true
 
 output:
   sort-results: true

pkg/provider/eks/eks.go

@@ -289,9 +289,8 @@ func (c *EKS) ClusterDelete(*kingpin.ParseContext) error {
 
 			if resL.NextToken == nil {
 				break
-			} else {
-				reqL.NextToken = resL.NextToken
 			}
+			reqL.NextToken = resL.NextToken
 		}
 
 		reqD := &eks.DeleteClusterInput{
@@ -496,7 +495,7 @@ func (c *EKS) AllNodeGroupsDeleted(*kingpin.ParseContext) error {
 }
 
 // EKSK8sToken returns aws iam authenticator token which is used to access eks k8s cluster from outside.
-func (c *EKS) EKSK8sToken(clusterName, region string) awsToken.Token {
+func (c *EKS) EKSK8sToken(clusterName, _ string) awsToken.Token {
 	gen, err := awsToken.NewGenerator(true, false)
 	if err != nil {
 		log.Fatalf("Token abstraction error: %v", err)

pkg/provider/gke/gke.go

@@ -593,7 +593,7 @@ func (c *GKE) ResourceDelete(*kingpin.ParseContext) error {
 }
 
 // GetDeploymentVars shows deployment variables.
-func (c *GKE) GetDeploymentVars(parseContext *kingpin.ParseContext) error {
+func (c *GKE) GetDeploymentVars(_ *kingpin.ParseContext) error {
 	fmt.Print("-------------------\n   DeploymentVars   \n------------------- \n")
 	for key, value := range c.DeploymentVars {
 		fmt.Println(key, " : ", value)

pkg/provider/kind/kind.go

@@ -200,7 +200,7 @@ func (c *KIND) ResourceDelete(*kingpin.ParseContext) error {
 }
 
 // GetDeploymentVars shows deployment variables.
-func (c *KIND) GetDeploymentVars(parseContext *kingpin.ParseContext) error {
+func (c *KIND) GetDeploymentVars(_ *kingpin.ParseContext) error {
 	fmt.Print("-------------------\n   DeploymentVars   \n------------------- \n")
 	for key, value := range c.DeploymentVars {
 		fmt.Println(key, ": ", value)

pkg/provider/provider.go

@@ -102,7 +102,7 @@ func DeploymentsParse(deploymentFiles []string, deploymentVars map[string]string
 	var fileList []string
 	for _, name := range deploymentFiles {
 		if file, err := os.Stat(name); err == nil && file.IsDir() {
-			if err := filepath.Walk(name, func(path string, f os.FileInfo, err error) error {
+			if err := filepath.Walk(name, func(path string, _ os.FileInfo, _ error) error {
 				if filepath.Ext(path) == ".yaml" || filepath.Ext(path) == ".yml" {
 					fileList = append(fileList, path)
 				}