Skip to content

Tool hub: flawfinder, cppcheck and DevSkim - #2325

Closed
remigiusz-antczak wants to merge 1 commit into
mainfrom
feat/hub-c-devskim-2
Closed

remigiusz-antczak wants to merge 1 commit into
mainfrom
feat/hub-c-devskim-2

Conversation

@remigiusz-antczak

Copy link
Copy Markdown
Collaborator

Routes three offline C/C++ and multi-language scanners through the review_checks.sh tool hub: flawfinder, cppcheck and Microsoft DevSkim.

  • Each is NOT CHECKED when missing, wired only once installed, and fail-closed on a crash, empty output, wrong shape or unexpected exit; changed files only.
  • DevSkim: one changed file per run; any non-zero exit is not run. Its own code has no HTTP, update or telemetry path; its NuGet dependencies were not audited, so dependency egress is marked unverified in tool-hub.md.
  • New suite scripts/test-review-checks-hub-c.sh (13/13).

Pre-existing failures that also occur on clean main: 3 scan-summary suites (host semgrep cache) and the size-gate test fixed by #2324.

🤖 Generated with Claude Code

Each tool is NOT CHECKED with an install hint when missing, counts as wired
only once installed, and is not run on a crash, empty output, wrong-shape
output or a non-zero exit. Changed files only, no network.

- flawfinder: --sarif, batch (GPLv2+).
- cppcheck: --xml-version=2, XML read from stderr, first <location> is the
  primary one (GPLv3).
- devskim: analyze --source-code accepts a single file, run once per file
  with --file-format sarif (MIT). Its own source has no HTTP, update or
  telemetry code; its NuGet dependencies were not audited, so dependency
  egress is marked unverified in tool-hub.md.

Flags, shapes and licenses were verified against man pages, manuals and
cloned source fetched 2026-11-12 (docs/standards-index.md). Fixtures use the
cppcheck manual sample verbatim; the flawfinder SARIF follows the tool's
source shape; the devskim SARIF is stub-only. Not routed: none.

size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 43180→46217 three hub rows with their verification and egress evidence

Tests: scripts/test-review-checks-hub-c.sh 13/13. Affected ci-tests suites
otherwise pass except pre-existing failures that fail identically on clean
origin/main 49a330c: the 3 scan-summary suites (host semgrep cache,
"FAIL default excludes") and the size-gate test
test_index_has_a_size_budget_and_the_gate_fires_when_it_is_exceeded
(low-context-index, train-budget).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@remigiusz-antczak

Copy link
Copy Markdown
Collaborator Author

Superseded by #2344.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant