Repository navigation
CI: persist-credentials false on every checkout - #2331
Closed
remigiusz-antczak wants to merge 1 commit into
Closed
remigiusz-antczak wants to merge 1 commit into
remigiusz-antczak wants to merge 1 commit into
Conversation
All six actions/checkout steps (five in ci.yml, one in release.yml) now set persist-credentials: false; no later step pushes, tag-pushes or fetches a private ref, and gh release create authenticates via GH_TOKEN env. A new offline test, registered in scripts/ci-tests.d, fails any checkout that omits it unless the step carries a zizmor: ignore[artipacked] reason. Verdicts: 6 not needed (set false), 0 needed (kept). Tests: 9/9 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by #2332. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
persist-credentials: falseon all sixactions/checkoutsteps inci.ymlandrelease.yml, which fixes zizmor's 6 mediumartipackedfindings.No later step in these jobs runs git push, fetches a private ref or pushes a tag;
gh release createauthenticates through theGH_TOKENenv var. A token left persisted in.git/configis therefore never used, but it is exposed to every later step and to any uploaded artifact.scripts/test_workflow_persist_credentials.py, wired viaci-tests.d, fails on any checkout that lacks the setting, unless the checkout carries an explicitzizmor: ignore[artipacked]comment with a reason.Gates: zizmor
artipacked0, actionlint rc 0.Tests: 9/9 (the new test + 8 workflow-grepping suites).
🤖 Generated with Claude Code