Skip to content

CI: persist-credentials false on every checkout - #2331

Closed
remigiusz-antczak wants to merge 1 commit into
mainfrom
ci/persist-credentials
Closed

remigiusz-antczak wants to merge 1 commit into
mainfrom
ci/persist-credentials

Conversation

@remigiusz-antczak

Copy link
Copy Markdown
Collaborator

Sets persist-credentials: false on all six actions/checkout steps in ci.yml and release.yml, which fixes zizmor's 6 medium artipacked findings.

No later step in these jobs runs git push, fetches a private ref or pushes a tag; gh release create authenticates through the GH_TOKEN env var. A token left persisted in .git/config is therefore never used, but it is exposed to every later step and to any uploaded artifact.

scripts/test_workflow_persist_credentials.py, wired via ci-tests.d, fails on any checkout that lacks the setting, unless the checkout carries an explicit zizmor: ignore[artipacked] comment with a reason.

Gates: zizmor artipacked 0, actionlint rc 0.

Tests: 9/9 (the new test + 8 workflow-grepping suites).

🤖 Generated with Claude Code

All six actions/checkout steps (five in ci.yml, one in release.yml) now set
persist-credentials: false; no later step pushes, tag-pushes or fetches a
private ref, and gh release create authenticates via GH_TOKEN env. A new
offline test, registered in scripts/ci-tests.d, fails any checkout that omits
it unless the step carries a zizmor: ignore[artipacked] reason.

Verdicts: 6 not needed (set false), 0 needed (kept).
Tests: 9/9

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@remigiusz-antczak

Copy link
Copy Markdown
Collaborator Author

Superseded by #2332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant