Skip to content

Hermetic scan-summary strip; pin pyyaml in CI - #2336

Merged
remigiusz-antczak merged 2 commits into
mainfrom
fix/hermetic-pyyaml
Nov 13, 2026
Merged

remigiusz-antczak merged 2 commits into
mainfrom
fix/hermetic-pyyaml

Conversation

@remigiusz-antczak

@remigiusz-antczak remigiusz-antczak commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Two small hardening fixes.

  • scripts/test-review-checks-scan-summary.sh: the "default excludes" check grepped the raw scanner arg logs for worktrees. Every lane runs from a .claude/worktrees/<name> checkout, so worktrees showed up in the absolute --config path and the check failed. The check now strips the checkout path from the logs first (a literal bash substitution, ${l//"$ROOT"/}) and then greps. scripts/test-review-checks-scan-summary-hermetic.sh also runs the test from a worktrees-style path, so this regression is caught.
  • .github/workflows/ci.yml pins pyyaml==6.0.3 next to the existing hypothesis pin. The checkout-credentials guard from CI: drop persisted checkout credentials, guard with a strict YAML test #2334 fails closed without PyYAML, so the job no longer relies on the runner image shipping it.

Local runs:

  • The hermetic scan-summary test passes both cases.
  • scripts/test-ci-gates.sh passes 303 of 311. The 8 failures are the same ones the base branch shows in this sandbox: the size budget and the serial-gate lock.

CI: 11 of 11 checks green.

🤖 Generated with Claude Code

Scan-summary test strips the checkout path with a literal loop instead of sed, so lane worktree paths no longer trip the default-excludes check. CI pins pyyaml==6.0.3 next to hypothesis because scripts/test_workflow_persist_credentials.py fails closed without it.

Tests: 303/311 (8 sandbox-baseline fails noted: size budget on base, serial_gate lock; 2 skipped)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@remigiusz-antczak
remigiusz-antczak marked this pull request as ready for review November 13, 2026 10:57
@remigiusz-antczak
remigiusz-antczak merged commit e895360 into main Nov 13, 2026
12 checks passed
@remigiusz-antczak
remigiusz-antczak deleted the fix/hermetic-pyyaml branch November 13, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant