Repository navigation
Hermetic scan-summary strip; pin pyyaml in CI - #2336
Merged
Merged
Conversation
Scan-summary test strips the checkout path with a literal loop instead of sed, so lane worktree paths no longer trip the default-excludes check. CI pins pyyaml==6.0.3 next to hypothesis because scripts/test_workflow_persist_credentials.py fails closed without it. Tests: 303/311 (8 sandbox-baseline fails noted: size budget on base, serial_gate lock; 2 skipped) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
remigiusz-antczak
marked this pull request as ready for review
November 13, 2026 10:57
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small hardening fixes.
scripts/test-review-checks-scan-summary.sh: the "default excludes" check grepped the raw scanner arg logs forworktrees. Every lane runs from a.claude/worktrees/<name>checkout, soworktreesshowed up in the absolute--configpath and the check failed. The check now strips the checkout path from the logs first (a literal bash substitution,${l//"$ROOT"/}) and then greps.scripts/test-review-checks-scan-summary-hermetic.shalso runs the test from a worktrees-style path, so this regression is caught..github/workflows/ci.ymlpinspyyaml==6.0.3next to the existinghypothesispin. The checkout-credentials guard from CI: drop persisted checkout credentials, guard with a strict YAML test #2334 fails closed without PyYAML, so the job no longer relies on the runner image shipping it.Local runs:
scripts/test-ci-gates.shpasses 303 of 311. The 8 failures are the same ones the base branch shows in this sandbox: the size budget and the serial-gate lock.CI: 11 of 11 checks green.
🤖 Generated with Claude Code