Skip to content

Fix comment parsed as a shellcheck directive in test-provision-tools.sh - #2346

Closed
remigiusz-antczak wants to merge 1 commit into
mainfrom
fix/shellcheck-directive-comment
Closed

remigiusz-antczak wants to merge 1 commit into
mainfrom
fix/shellcheck-directive-comment

Conversation

@remigiusz-antczak

Copy link
Copy Markdown
Collaborator

The comment on line 177 began with # shellcheck,, which shellcheck parses as a directive. It failed with SC1073/SC1072 and stopped checking the rest of the file. The comment is reworded. No other tracked script has this pattern.

Tests: 61/61 (test-provision-tools.sh). shellcheck -S warning on the file now exits 0.

🤖 Generated with Claude Code

A comment starting with '# shellcheck, ruff and ...' is parsed by shellcheck as a directive (SC1073/SC1072), so shellcheck stopped checking the file. Reword to '# The shellcheck, ruff and ...'. No other tracked *.sh file has a non-directive '# shellcheck' comment. shellcheck -S warning now reports no findings on the file.

Tests: 61/61

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@remigiusz-antczak

Copy link
Copy Markdown
Collaborator Author

Superseded: main already carries this fix (merged in #2339).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant