Repository navigation
Gitleaks: narrow the fixture allowlist and run the guard in CI - #2354
Merged
Merged
Conversation
.gitleaks.toml exempts only the fictional fixture values in the two secret test scripts instead of whole files; its comment states the value regexes apply repo-wide. .gitleaksignore lists the fingerprints of the 19 remaining history hits, all triaged as fictional, so a history scan reports 0 findings. test_gitleaks_allowlist.sh asserts the 0-finding history scan (skipped on shallow checkouts), counts a probe as detected only on exit 1 plus an aws-access-token report (any other exit fails), and fails when gitleaks is missing under REQUIRE_GITLEAKS=1. Add a gitleaks job to ci.yml: full-history checkout without persisted credentials, gitleaks 8.30.1 installed from its release tarball and verified against a hardcoded sha256, then REQUIRE_GITLEAKS=1 bash scripts/test_gitleaks_allowlist.sh. The gates aggregate needs it; job permissions stay contents: read. The guard is strict (missing gitleaks, shallow history or no .git FAILs) only when REQUIRE_GITLEAKS=1 is set. Keying strictness on CI broke the per-PR test legs, which run every test script with CI set but do not install gitleaks; they now SKIP it. Supersedes #2351 and #2352. Tests: 3/3 test_gitleaks_allowlist.sh runs (PASS with gitleaks; SKIP with CI=1 and no gitleaks; FAIL with REQUIRE_GITLEAKS=1 and no gitleaks). actionlint clean; size gate ok. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # SHA256SUMS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #2351 and #2352 into one commit and fixes a CI failure in #2351. The per-PR test legs run every test script with CI set but do not install gitleaks, so the guard failed with "gitleaks not installed". Now only REQUIRE_GITLEAKS=1 makes the guard strict, and the dedicated gitleaks job sets it.
Tests: 3/3 guard runs (PASS with gitleaks; SKIP with CI=1 and no gitleaks; FAIL with REQUIRE_GITLEAKS=1 and no gitleaks). actionlint is clean and the size gate passes.
🤖 Generated with Claude Code