Repository navigation
Tool hub: route rubocop Security cops; terrascan documented as not routed - #2359
Merged
Merged
Conversation
…uted Adds rubocop (changed Ruby files, Security department cops only, built-in default config so a project .rubocop.yml that can require code is never loaded) to the hub. NOT CHECKED when missing; not run on a crash, empty output, wrong-shape output, a summary that disagrees with its files list, an unexpected exit, or an inspected-file count that differs from the files passed (regression test fails without that guard). terrascan is recorded as not routed: its repository is archived and its first scan downloads policies. Exit codes, JSON keys and cop names from upstream docs fetched 2026-11-13; --force-default-config and --cache false are marked unverified; stub-tested only. SHA256SUMS and docs/INDEX.md are rebuilt at land time. size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 54797→56235 rubocop row and terrascan not-routed row with verification evidence Tests: 23/23 (hub-rubocop 11, hub-rb-cfn 12) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ocop*.yml is NOT CHECKED An independent review found two fail-open gaps. --only Security hid Lint/Syntax, so a file that did not parse read clean: rubocop now runs all cops on the default config, sjson keeps Security/* rows only, and any error or fatal non-Security offense is not run (the only valid exit is 0 under --fail-level fatal). A diff that changes a .rubocop*.yml is NOT CHECKED because project config can require code, and a stub that honors --force-default-config proves a planted config disabling Security/Eval does not hide the row. The syntax-error test fails without the sjson check. --force-default-config and --fail-level fatal stay marked unverified; an unsupported flag exits 2 and is not run. size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 54797→56545 rubocop row and terrascan not-routed row with verification evidence Tests: 25/25 (hub-rubocop 13, hub-rb-cfn 12) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rebase tool-hub.md size budget to 58341 and refresh derived indexes. Tests: 59/59 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds rubocop to the hub for changed Ruby files. It runs all cops on the built-in default config (--force-default-config), keeps only Security/* rows, and treats any error or fatal non-Security offense (such as Lint/Syntax) as not run, so a file that does not parse cannot read clean. A diff that changes a .rubocop*.yml is NOT CHECKED, because project config can require code. rubocop is NOT CHECKED when missing, and not run on a crash, empty or wrong-shape output, a summary that disagrees with its file list, an inspected-file count that differs from the files passed, or any exit other than 0. terrascan is recorded as not routed: its repository is archived and its first scan downloads policies.
An independent review found two fail-open gaps (--only Security hid parse failures, and project config isolation was untested). Both are fixed, with regression tests that fail before the fix. Exit codes, JSON keys and cop names come from upstream docs; --force-default-config, --fail-level fatal and --cache false are marked unverified, and the tests use stub binaries.
Tests: 59/59 (hub-rubocop 13, hub-tf-ansible 21, hub-rb-cfn 12, hub-c 13). The size gate and size ratchet pass.
🤖 Generated with Claude Code