Repository navigation
Hub: mark same file:line findings from several tools as corroborated, dropping no rows - #2381
Merged
Merged
Conversation
… dropping no rows review_checks.sh now adds a tools list and a " [corroborated by: ...]" suffix to every row where different tools flag the same normalized file:line. No row is dropped or merged, so per-tool row consumers keep working. not-checked, summary, line<=0 and per-file-summary rows are skipped. Tests: 6/6 hub-dedup, test-review-checks.sh pass, test_cost_limit_map.py 9/9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e one scanner test_review_checks_full_wiring compares exact row text, so it now strips the trailing " [corroborated by: ...]" suffix before comparing. The corroboration block in review_checks.sh normalizes gitleaks-history to gitleaks before counting distinct tools, so the two alone are not corroboration; a new case in test-review-checks-hub-dedup.sh covers it. Tests: 4/4 (route_auth_map, hub-dedup, review-checks, cost_limit_map); 7 related python suites also green Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review_checks.sh now adds a tools list and a " [corroborated by: ...]" suffix to every row where different tools flag the same normalized file:line. No row is dropped or merged, so per-tool row consumers keep working. not-checked, summary, line<=0 and per-file-summary rows are skipped.
Tests: 6/6 hub-dedup, test-review-checks.sh pass, test_cost_limit_map.py 9/9
🤖 Generated with Claude Code