Skip to content

Hub: mark same file:line findings from several tools as corroborated, dropping no rows - #2381

Merged
remigiusz-antczak merged 3 commits into
mainfrom
feat/hub-real-smoke-17
Nov 15, 2026
Merged

remigiusz-antczak merged 3 commits into
mainfrom
feat/hub-real-smoke-17

Conversation

@remigiusz-antczak

Copy link
Copy Markdown
Collaborator

review_checks.sh now adds a tools list and a " [corroborated by: ...]" suffix to every row where different tools flag the same normalized file:line. No row is dropped or merged, so per-tool row consumers keep working. not-checked, summary, line<=0 and per-file-summary rows are skipped.

Tests: 6/6 hub-dedup, test-review-checks.sh pass, test_cost_limit_map.py 9/9

🤖 Generated with Claude Code

remigiusz-antczak and others added 3 commits November 15, 2026 14:21
… dropping no rows

review_checks.sh now adds a tools list and a " [corroborated by: ...]" suffix to every row where different tools flag the same normalized file:line. No row is dropped or merged, so per-tool row consumers keep working. not-checked, summary, line<=0 and per-file-summary rows are skipped.

Tests: 6/6 hub-dedup, test-review-checks.sh pass, test_cost_limit_map.py 9/9

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e one scanner

test_review_checks_full_wiring compares exact row text, so it now strips the trailing " [corroborated by: ...]" suffix before comparing. The corroboration block in review_checks.sh normalizes gitleaks-history to gitleaks before counting distinct tools, so the two alone are not corroboration; a new case in test-review-checks-hub-dedup.sh covers it.

Tests: 4/4 (route_auth_map, hub-dedup, review-checks, cost_limit_map); 7 related python suites also green

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@remigiusz-antczak
remigiusz-antczak merged commit fc52e64 into main Nov 15, 2026
13 checks passed
@remigiusz-antczak
remigiusz-antczak deleted the feat/hub-real-smoke-17 branch November 15, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant