This repository was archived by the owner on Jan 2, 2024. It is now read-only.
Output sub-item form-errors messages when they exist #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating an array Laravel lets us validate array items using the
fieldname.*syntax which can result in the error bag containing messages which are returned asfieldname.<array_index>.These are not output at the moment, this PR is a simple fix to (recursively) output them if they exist.
I've just extended the
<x-form-errors>component to output them as their own messages, an enhancement might be to make them smarter or display in a more inline way..There were no existing tests for form-errors, so apologies for not adding one and starting those.