feat: add knob to customise on{Request,Response}Headers StopIteration behavior #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonm1
approved these changes
Jul 11, 2025
Signed-off-by: Michael Warres <[email protected]>
mpwarres
force-pushed
the
request-headers-stop-iteration
branch
from
3ec2095 to
02239af
Compare
It was testing the same case twice. Signed-off-by: Michael Warres <[email protected]>
martijneken
requested changes
Jul 12, 2025
Rename option to allow_on_headers_stop_iteration and test onResponseHeaders behavior as well. Signed-off-by: Michael Warres <[email protected]>
Thanks for catching that--done. |
mpwarres
changed the title
Signed-off-by: Michael Warres <[email protected]>
Signed-off-by: Michael Warres <[email protected]>
Previously, the test was creating a new wasm_handle and plugin_handle for each request, which led to the WasmHandleBase destructor calling wasm_base_->startShutdown() mid-test. Apparently V8 tolerates this, but WAMR (correctly) does not. Signed-off-by: Michael Warres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protected ContextBase::allow_on_headers_stop_iteration_ field that can be used by host implementations to control whether or not ContextBase propagates FilterHeaderStatus::StopIteration returned by onRequestHeaders() or onResponseHeaders() without modification.
Follow-on envoyproxy/envoy#40213 adds an option in Envoy WasmFilter PluginConfig that sets the value of this field.
For details, see Envoy Wasm / Proxy-Wasm support for FilterHeadersStatus::StopIteration. This PR is one part of implementing Option B: WasmFilter config knob.
Note that default behavior of proxy-wasm-cpp-host and ContextBase is unchanged.