Skip to content

Ignore clippy's manual_is_multiple_of warning. #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025

Conversation

PiotrSikora
Copy link
Member

@PiotrSikora PiotrSikora commented Jul 2, 2025

unsigned_is_multiple_of() was stabilized very recently, and while
the suggested code might be more idiomatic, it's not supported by
our MSRV or even the stable version currently used in rules_rust.

unsigned_is_multiple_of() was stabilized very recently, and while
the suggested code might be more idiomatic, it's not supported by
our MSRV or even the stable version currently used in rules_rust.

Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora PiotrSikora changed the title Use is_multiple_of(2) instead of modulo. Ignore clippy's manual_is_multiple_of warning. Jul 2, 2025
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora PiotrSikora merged commit 50229a2 into proxy-wasm:main Jul 2, 2025
23 checks passed
@PiotrSikora PiotrSikora deleted the no_modulo branch July 2, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants