-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some paths moves into config #101
base: lazy_load
Are you sure you want to change the base?
Conversation
Implemented new view mode "split" (in filemanager.config.json -> options -> filemaagerMode = 'split'). |
Could you post a screenshot of the "Split view mode"? |
… was in main view)
The screenshot does not show an expanded folder, so it's hard to see the feature in action. But I think it makes the tree show only dirs, and the main panel show only files...? What is the white box in the upper left, covering most of the tree? |
@@ -236,7 +236,7 @@ public function handleRequest() | |||
break; | |||
|
|||
case 'getfolder': | |||
if($this->getvar('path') && $this->getvard('skip', true, 0)) { | |||
if($this->getvar('path') && $this->getvard('skip', true, 0) && $this->getvard('load', true, 0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getvard()? Probably should be getvar().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look for new function getvard
which don't throw error if variable wasn't set. 3rd argument is default value which will be used if name not defined in $_GET.
Hey @Iworb Thanks for the commits. I am reviewing and can see that the implementation breaks some features, so I have to rewrite lazy loading in a bit different way, however I can use many of your ideas. Most likely I will have to close this PR, but feel free to continue commit changes if you have any. Your contribution is very valuable. |
Heya, @servocoder Okay, I think I will take a look for my own connector and than join to your lazy_loading branch again. |
No description provided.