Skip to content

fix: ci, use app icon in native builds#26

Merged
pszemraj merged 7 commits intomainfrom
fix/ci
Feb 25, 2026
Merged

fix: ci, use app icon in native builds#26
pszemraj merged 7 commits intomainfrom
fix/ci

Conversation

@pszemraj
Copy link
Copy Markdown
Owner

Hardens the release-gui pipeline to fix the two release blockers and improve resilience against runner/tooling drift.

What changed

  • Updated .github/workflows/release-gui.yml
    • Added weekly schedule trigger (current_ref dry-run mode).
    • Pinned Windows runner to windows-2022.
    • Replaced WiX install with a capability check/install step (Ensure WiX Toolset (major 3)).
    • Fixed Windows PowerShell env parsing for ProgramFiles(x86) (post-iteration fix).
    • Added --locked to release/smoke build commands.
    • Hardened Linux AppImage verification:
      • capture --appimage-version with 2>&1
      • validate extracted payload (--appimage-extract, expected binary + .desktop).
  • Updated .github/scripts/release_gui_prepare.py
    • WiX discovery now evaluates candidates and selects matching expected major.
  • Updated .github/scripts/release_gui_collect.py
    • Artifact collection now tolerates extension casing variants:
      • .AppImage/.appimage
      • .msi/.MSI
      • .dmg/.DMG
  • Updated .github/scripts/validate_workflow.py
    • Release matrix expectation now uses windows-2022.

Why

  • Fixes Windows failure caused by WiX version conflict on hosted runners.
  • Fixes Linux false negative where AppImage runtime version is emitted on stderr.
  • Reduces fragility from runner image/toolchain churn.

Validation

Notes

  • This PR includes full CI hardening scope plus one follow-up Windows script fix discovered during live CI execution.

@pszemraj
Copy link
Copy Markdown
Owner Author

@codex review

@pszemraj pszemraj changed the title Fix/ci fix: ci, use app icon in native builds Feb 25, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ac96ef8fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/localpaste_gui/src/lib.rs
@pszemraj
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pszemraj pszemraj merged commit 93d5bd2 into main Feb 25, 2026
1 check passed
@pszemraj pszemraj deleted the fix/ci branch February 25, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant