feat: add node stack to thread data#347
Merged
Merged
Conversation
This is the start of the and types to use as part of . This will allow us to track node specific information that is expensive to recompute. Yoinked from the engine. bench: 1352109
Added a helper to check if a given score (i32) is valid
bench: 1352109
bench: 1352109
bench: 1352109
Changes: - Implemented a NodeStack along with a Node to track data for searched nodes. - Integrated new NodeStack into the ThreadData structure. - Integrate improvement tracking into RFP margin computation. Shrink the margin if we are improving. ``` Elo | 4.82 +- 3.70 (95%) SPRT | 8.0+0.08s Threads=1 Hash=16MB LLR | 2.98 (-2.94, 2.94) [0.00, 5.00] Games | N: 15658 W: 4509 L: 4292 D: 6857 Penta | [392, 1871, 3152, 1956, 458] ``` https://openbench.nocturn9x.space/test/6919/ bench: 1301394
Owner
Author
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
NodeStackalong with aNodeto track data for searched nodes.NodeStackinto theThreadDatastructure.This is part 2 of 2 in a stack made with GitButler: