Fix patch and incremental patch for nested values #7432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk for deeply nested values
…he patch into the document using `@fastify/deepmerge` package. This prevents an issue that can arise when calling `patch` or `incrementalPatch` with a patch value containing fields deeper that the top level of the document where values will be spliced out if the patch value does not contain a full copy of all fields instead of just the fields being patched.
alex-zywicki
force-pushed
the
fix-patch-and-incremental-patch-for-nested-values
branch
from
362a10c to
832b21e
Compare
|
After looking at the issues with the CI build related to the "object-deep-merge" package I opted to replace that with "@fastify/deepmerge" which I verified locally should build. The tests as a I wrote them still pass with the changed lib. I also made sure that the merge behavior for arrays overwrites arrays with the "patch" value as I believe this is the behavior that is intended in patch. A lot of these 3rd party libs want to concat the arrays by default. |
|
@pubkey Can you approve the workflow so we can hopefully move forward with this? Or is there something you would need changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
patchandincrementalPatchThis PR contains 2 commits that:
Describe the problem you have without this PR
patch`and incrementalPatch can splice out nested values #7430
Todos