Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vocabulary for plot2 #11118

Closed

Conversation

illyShelly
Copy link
Contributor

@illyShelly illyShelly commented May 5, 2022

Add new vocabulary to .yml file to support more languages.

Fixes #11117

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented May 5, 2022

@github-actions
Copy link

github-actions bot commented May 5, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6394925682/artifacts/232619971

@illyShelly illyShelly changed the title new vocabulary in czech for plot2 new vocabulary for plot2 May 5, 2022
Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🎉 thanks @illyShelly

@illyShelly
Copy link
Contributor Author

Thank you @cesswairimu I'll slowly continue on it 💯

@cesswairimu
Copy link
Collaborator

please let me know if/when its ready to be merged :). Thanks

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6502361825/artifacts/241526027

@codeclimate
Copy link

codeclimate bot commented May 14, 2022

Code Climate has analyzed commit b2ff070 and detected 0 issues on this pull request.

View more on Code Climate.

@illyShelly illyShelly changed the title new vocabulary for plot2 New vocabulary for plot2 May 15, 2022
@jywarren
Copy link
Member

It took a lot of scrolling but here is the error!

https://github.com/publiclab/plots2/runs/6437218263?check_suite_focus=true#step:9:96

ERROR QuestionTest#test_posting_a_question (94.57s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find visible css ".alert-success"
            test/system/post_question_test.rb:66:in `block in <class:QuestionTest>'

I think this one is an intermittent one unrelated to your code which we can get past by restarting the test!

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6508880717/artifacts/242477196

@jywarren
Copy link
Member

Looks like it passed!! Is it ready for a final review?

@illyShelly
Copy link
Contributor Author

@jywarren sorry, I missed your message. I will add some more to be able to 'launch' new language on the website. Size +/- the French translation. Thank you 🙂

@stale
Copy link

stale bot commented May 20, 2023

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label May 20, 2023
@stale stale bot closed this Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend cz.yml file
3 participants