-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New vocabulary for plot2 #11118
New vocabulary for plot2 #11118
Conversation
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic 🎉 thanks @illyShelly
Thank you @cesswairimu I'll slowly continue on it 💯 |
please let me know if/when its ready to be merged :). Thanks |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Code Climate has analyzed commit b2ff070 and detected 0 issues on this pull request. View more on Code Climate. |
It took a lot of scrolling but here is the error! https://github.com/publiclab/plots2/runs/6437218263?check_suite_focus=true#step:9:96
I think this one is an intermittent one unrelated to your code which we can get past by restarting the test! |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Looks like it passed!! Is it ready for a final review? |
@jywarren sorry, I missed your message. I will add some more to be able to 'launch' new language on the website. Size +/- the French translation. Thank you 🙂 |
Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add |
Add new vocabulary to .yml file to support more languages.
Fixes #11117
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below