Code

[API] Commenting through a token#1513

Code

Merged

jywarren merged 14 commits intopubliclab:masterpubliclab/plots2:masterfrom ryzokuken:api-commentryzokuken/plots2:api-commentCopy head branch name to clipboardJul 11, 2017

+102-6

Commits

Commits on Jul 8, 2017

• Start working on a function to add commenting feature through a token

  ryzokuken

  committed
  7579f8d

  Copy full SHA for 7579f8d

• Add authorization

  ryzokuken

  committed
  829fae9

  Copy full SHA for 829fae9

• Avoid ruby hash rocket syntax

  ryzokuken

  committed
  a095e8d

  Copy full SHA for a095e8d

• Facepalm

  ryzokuken

  committed
  0ff8697

  Copy full SHA for 0ff8697

Commits on Jul 9, 2017

• Start working on a private function for adding comments

  ryzokuken

  committed
  195bc07

  Copy full SHA for 195bc07

• Finalize the original function using the private helper

  ryzokuken

  committed
  787134c

  Copy full SHA for 787134c

• Make comment_by_token method using the private function

  ryzokuken

  committed
  a5834f1

  Copy full SHA for a5834f1

• Move CommentError and create_comment to CommentHelper

  ryzokuken

  committed
  d2846ac

  Copy full SHA for d2846ac

• Write first functional test; Introduce wierd 406 error

  ryzokuken

  committed
  917c90e

  Copy full SHA for 917c90e

Commits on Jul 10, 2017

• Fix 406 issue

  ryzokuken

  committed
  48ecaae

  Copy full SHA for 48ecaae

• Add second test and improve responses

  ryzokuken

  committed
  f80878b

  Copy full SHA for f80878b

• Fix test names

  ryzokuken

  committed
  61bca00

  Copy full SHA for 61bca00

• Add test for invalid comment

  ryzokuken

  committed
  e513cdd

  Copy full SHA for e513cdd

• Add recommendations

  ryzokuken

  committed
  1a9c61e

  Copy full SHA for 1a9c61e