Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create relations for existing discussions #969

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gabestein
Copy link
Member

Issue(s) Resolved

If a pub (or pub-discussion relationship) was deleted, the gdrive action would fail to create relationships between the pub and existing discussions.

High-level Explanation of PR

If a discussion already exists, it tries to create a new relation for it via the upsert function. We could make this a tiny bit more efficient by checking for the existence of a relationship already and not passing it in, but as the upsert function already does this, seems fine for now.

Test Plan

  1. Delete a pub that has some discussions
  2. Delete a discussion
  3. Re-run the google drive action
  4. All discussions should appear as related to the pub, once
  5. No duplicate discussions should be created

Screenshots (if applicable)

Notes

@gabestein gabestein requested a review from isTravis February 11, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants