FuseSoC and XSIM

[micprog]

Improves compatibility for fusesoc and vivado xsim and includes a limited test for this in the internal CI. Replaces #232. Fixes #226, #247.

[thommythomaso]

we should add a version here and use the newest one installed (vitis-2022.1-zr)

[thommythomaso]

Mention vitis and fusesoc CI maybe?

[thommythomaso]

LGTM!

[skokvermon]

Juste tested this branch and it is not working

`ifdef XSIM is not working with vivado xsim

fusesoc run --tool xsim --target sim_xbar --no-export pulp-platform.org::axi:0.37.0

ERROR: [VRFC 10-2991] 'randomize' is not declared under prefix 'w_beat' [/home/skok/pkgs/testFuse/fusesoc_libraries/axi/src/axi_test.sv:1204]
ERROR: [VRFC 10-2991] 'randomize' is not declared under prefix 'r_beat' [/home/skok/pkgs/testFuse/fusesoc_libraries/axi/src/axi_test.sv:1364]
ERROR: [VRFC 10-2991] 'randomize' is not declared under prefix 'b_beat' [/home/skok/pkgs/testFuse/fusesoc_libraries/axi/src/axi_test.sv:1464]

You have to replace all `ifdef XSIM by `ifdef XILINX_SIMULATOR

Official source is here:
https://docs.xilinx.com/r/en-US/ug900-vivado-logic-simulation/Predefined-Macros

#232 has correct fixes which have been removed by this PR

[skokvermon]

commit 2fb9778
has to be reverted and fixed

[skokvermon]

depends on pulp-platform/common_cells#139

[thommythomaso]

Which version of XSIM do you use?

[thommythomaso]

We use Vivado 2022.04 in the CI, which works just fine for us.

[skokvermon]

I have vivado 2022.1
CI use sim target which works.
Most other bench targets will show the randomize error message
Unfortunately, if you correct it, you will mostly have unsupported default disable iff
Then if corrected, I had seg fault on axi_xbar bench which I can't find any workaround.

I found out that I could workaround one of these segfaults in my own bench by replacing

      axi_drv_t::ax_beat_t ax_beat = new();

by

      axi_test::axi_driver #(.AW(AXI_AW), .DW(AXI_DW), .IW(AXI_IW), .UW(AXI_UW))::ax_beat_t ax_beat = new();

It doesn't like using a subtype of a typedef type.
However, I can't make axi_xbar bench to work

[thommythomaso]

I have vivado 2022.1 CI use sim target which works. Most other bench targets will show the randomize error message Unfortunately, if you correct it, you will mostly have unsupported default disable iff Then if corrected, I had seg fault on axi_xbar bench which I can't find any workaround.

I found out that I could workaround one of these segfaults in my own bench by replacing

      axi_drv_t::ax_beat_t ax_beat = new();

by

      axi_test::axi_driver #(.AW(AXI_AW), .DW(AXI_DW), .IW(AXI_IW), .UW(AXI_UW))::ax_beat_t ax_beat = new();

It doesn't like using a subtype of a typedef type. However, I can't make axi_xbar bench to work

I just tried it locally as well and it fails with the sim_xbar target. I will revert the define ofc. Sorry for that.

Can you maybe create a new PR with all the fixes you require for the xbar TB to work?

[skokvermon]

#264

sim_xbar bench segfaults...
however sim_lite_xbar works (but doesn't seem to end)