Michaero/bump ci #15
Merged
Michaero/bump ci #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micprog
force-pushed
the
michaero/bump-ci
branch
from
01588d3 to
90ee53e
Compare
Scheremo
reviewed
May 21, 2025
Scheremo
approved these changes
May 21, 2025
Scheremo
left a comment
Scheremo
left a comment
There was a problem hiding this comment.
Great idea! Love that you supply the formatting config + CI hooks.
I left some minor comments to try to comply more closely with the lowrisc style guide, but imo this is not so important if any automated formatting is enforced.
Makefile
Outdated
|
|
||
| .PHONY: format | ||
| format: | ||
| verible-verilog-format ./src/*.sv ./test/*.sv ./test/synth/*.sv --inplace --flagfile .verilog_format |
There was a problem hiding this comment.
Just an idea, but you might think about using a bender flist instead of maintaining this make target separately.
micprog
force-pushed
the
michaero/bump-ci
branch
2 times, most recently
from
5e93533 to
1e1364d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.