Skip to content

Fix bad connections to dead_response_fifo for hidestrb case #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
micprog wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Fix bad connections to dead_response_fifo for hidestrb case #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/stream_mem_to_banks_det.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@ module stream_mem_to_banks_det #(
assign gnt_o = (&req_ready) & (&resp_ready) & !dead_write_fifo_full;

if (HideStrb) begin : gen_dead_write_fifo

logic [NumBanks-1:0] zero_strobe_on_input;
for (genvar i = 0; unsigned'(i) < NumBanks; i++) begin : gen_zero_strobe_on_input
assign zero_strobe_on_input[i] = (strb_i[i*BytesPerBank+:BytesPerBank] == '0);
end

fifo_v3 #(
.FALL_THROUGH(1'b0),
.DEPTH (MaxTrans + 1),
Expand All @@ -178,7 +184,7 @@ module stream_mem_to_banks_det #(
.full_o (dead_write_fifo_full),
.empty_o (dead_write_fifo_empty),
.usage_o (),
.data_i ({NumBanks{we_i}} & zero_strobe),
.data_i (we_i ? zero_strobe_on_input : '0),
.push_i (req_i & gnt_o),
.data_o (dead_response_unmasked),
.pop_i (rvalid_o & rready_i)
Expand Down