sw: Add more complex Snitch application tests#79
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
colluca
force-pushed
the
lleone/mcast-kernels-mapping
branch
from
6e26ff8 to
b3e900a
Compare
colluca
force-pushed
the
lleone/mcast-kernels-mapping
branch
12 times, most recently
from
55c0a44 to
56f5d38
Compare
colluca
commented
Sep 3, 2025
Contributor
Author
colluca
left a comment
colluca
left a comment
There was a problem hiding this comment.
As a general comment, we may want to prefix all functions as we do with snrt_ in the Snitch runtime, perhaps with pb_. The primary advantage to me being that it communicates clearly where they are defined.
colluca
commented
Sep 3, 2025
Contributor
Author
colluca
left a comment
colluca
left a comment
There was a problem hiding this comment.
A few more comments I forgot to add before.
colluca
force-pushed
the
lleone/mcast-kernels-mapping
branch
3 times, most recently
from
43cb5c5 to
42936ab
Compare
Lore0599
force-pushed
the
lleone/mcast-kernels-mapping
branch
from
38adb2b to
99ac5d2
Compare
Lore0599
force-pushed
the
lleone/mcast-kernels-mapping
branch
from
99ac5d2 to
2aa5ff5
Compare
colluca
force-pushed
the
lleone/mcast-kernels-mapping
branch
2 times, most recently
from
7101db9 to
800a0d4
Compare
colluca
force-pushed
the
lleone/mcast-kernels-mapping
branch
from
800a0d4 to
0d447e1
Compare
colluca
force-pushed
the
lleone/mcast-kernels-mapping
branch
from
0d447e1 to
e5d4d2e
Compare
colluca
force-pushed
the
lleone/mcast-kernels-mapping
branch
from
8f6361e to
0a87358
Compare
colluca
force-pushed
the
lleone/mcast-kernels-mapping
branch
from
6d972c9 to
55aa6b7
Compare
fischeti
requested changes
Sep 15, 2025
Collaborator
fischeti
left a comment
fischeti
left a comment
There was a problem hiding this comment.
The snitch_cluster and common_cells bump look fine to me. I can remove the existing tapeout tag and recreate it once we merge this. I have some minor changes below.
Lore0599
force-pushed
the
lleone/mcast-kernels-mapping
branch
from
16c469b to
6485ded
Compare
fischeti
changed the title
fischeti
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributions:
vsim-run-batch-verifygoal for apps with verification script (also in PD repo)