-
Notifications
You must be signed in to change notification settings - Fork 62
Fix release script to match latest requirements from community portals #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: balasankarc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
[noissue] Signed-off-by: Balasankar 'Balu' C <[email protected]>
[noissue] Signed-off-by: Balasankar 'Balu' C <[email protected]>
…perator releases [noissue] Signed-off-by: Balasankar 'Balu' C <[email protected]>
b3780e2 to
1f197ec
Compare
| echo " replaces: pulp-operator.v${PULP_OPERATOR_REPLACE_VERSION}" >> $CSV_FILE | ||
|
|
||
| ANNOTATIONS_FILE=${CATALOG_DIR}/metadata/annotations.yaml | ||
| echo 'com.redhat.openshift.versions: "v4.17-v4.18"' >> $ANNOTATIONS_FILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mimicking what was done in last three releases for https://github.com/redhat-openshift-ecosystem/community-operators-prod/pulls?q=is%3Apr+pulp-operator+is%3Aclosed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #1573 to improve this situation.
|
|
||
| echo "Bumping Makefile operator's version ..." | ||
| sed -i -E "s/^(VERSION \?=) .*/\1 ${PULP_OPERATOR_DEV_VERSION}/g" Makefile | ||
| sed -i -E "s/^(VERSION \?=) .*/\1 ${PULP_OPERATOR_RELEASE_VERSION}/g" Makefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what we have been essentially doing since we went GA (1.0.0). Following YAGNI, maybe bring it back when we start doing dev builds again (like a potential 2.0 release?)
|
|
||
| echo "Updating containerImage annotation" | ||
| CSV_FILE=manifests/pulp-operator.clusterserviceversion.yaml | ||
| sed -i "s#containerImage: quay.io/pulp/pulp-operator:devel#containerImage: quay.io/pulp/pulp-operator:v${PULP_OPERATOR_RELEASE_VERSION}#g" $CSV_FILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason for CSV not to be as similar as possible between pulp-operator release, k8s community release, and openshift community release. So, this should be harmless.
49d1731 to
a72da87
Compare
[noissue] Signed-off-by: Balasankar 'Balu' C <[email protected]>
a72da87 to
395d949
Compare
Fix the release script to perform actions that are now required by https://github.com/k8s-operatorhub/community-operators and https://github.com/redhat-openshift-ecosystem/community-operators-prod