Update pkginfo library to support newer python packages #683
Conversation
|
Might need some fields added as well |
github-actions
bot
removed
the
multi-commit
dralley
force-pushed
the
dep-bump
branch
3 times, most recently
from
6a473a1
to
2c7bd88
Compare
|
I need to find a package that uses metadata version 2.3 and also uses this dynamic field, so that we can properly test it. edit: or maybe we need to make one. Is there anything in pulp_python currently like the test I added to pulp_rpm that uses a package constructed specifically to exercise every field available, and then checks the API response once uploaded / synced to verify that they match? |
|
Looks like the |
|
No we don't have any dynamic fixtures to create packages with specified fields. |
|
I don't mean dynamic fixtures necessarily, even a pre-generated package in the fixtures would be fine But I assume the answer there is also probably no. That's fine, I can make do |
pulp_python/app/models.py
Outdated
| @@ -178,6 +182,7 @@ class PythonPackageContent(Content): | |||
| classifiers = models.JSONField(default=list) | |||
| project_urls = models.JSONField(default=dict) | |||
| description_content_type = models.TextField() | |||
| dynamic = models.TextField() | |||
There was a problem hiding this comment.
I think we are missing provides_extra. Added in 2.1. Also, can we reformat the list to be like pkginfo? https://github.com/jwilk-mirrors/python-pkginfo/blob/master/pkginfo/distribution.py#L124
There was a problem hiding this comment.
Sure. For provides_extra, are we going to be missing metadata for existing packages? I don't think we ever had a problem with rejection of metadata 2.1 packages as we did with 2.3
How do you want to deal with that?
There was a problem hiding this comment.
Also, I filed pypi/warehouse#16190 because I'm having difficulty figuring out exactly what these fields are meant to look like. The core metadata specification describes how they're represented in the metadata files within a package, not how they're represented on PyPI.
There was a problem hiding this comment.
Sure. For
provides_extra, are we going to be missing metadata for existing packages? I don't think we ever had a problem with rejection of metadata 2.1 packages as we did with 2.3How do you want to deal with that?
We might need to create a new endpoint that runs a task to fix bad metadata. Unless you are uploading every package most python content will have incorrect metadata because syncing doesn't individually check the metadata for each package. Currently we take the latest's package metadata and re-use it for every version of that package.
dralley
force-pushed
the
dep-bump
branch
6 times, most recently
from
f0f7867
to
c490361
Compare
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
|
This pull request is no longer marked for closure. |
closes #682