forked from confused-Techie/atom-backend
-
-
Notifications
You must be signed in to change notification settings - Fork 10
Adding tag as a possible parameter to POST /packages #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mauricioszabo
wants to merge
6
commits into
main
Choose a base branch
from
new-package-considering-only-specific-tag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| out.versions[PACKAGE_VER] = buildMeta(opts); | ||
| buildAbsentVer(PACKAGE_VER, opts) |
Check notice
Code scanning / CodeQL
Semicolon insertion
Avoid automated semicolon insertion (95% of all statements in [the enclosing function](1) have an explicit semicolon).
| let tag; | ||
| if(possibleTag) { | ||
| tag = await provider.tag(userObj, ownerRepo, possibleTag); | ||
| tag = tag.content |
Check notice
Code scanning / CodeQL
Semicolon insertion
Avoid automated semicolon insertion (91% of all statements in [the enclosing function](1) have an explicit semicolon).
| tags.content.sort((a, b) => { | ||
| return semver.rcompare(a.name, b.name); | ||
| }); | ||
| tag = tags.content[0] |
Check notice
Code scanning / CodeQL
Semicolon insertion
Avoid automated semicolon insertion (91% of all statements in [the enclosing function](1) have an explicit semicolon).
| tag = await provider.tag(userObj, ownerRepo, possibleTag); | ||
| tag = tag.content | ||
| } else { | ||
| tags = await provider.tags(userObj, ownerRepo); |
Check warning
Code scanning / CodeQL
Missing variable declaration
Variable tags is used like a local variable, but is missing a declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Filling out the template is required.
All new code requires tests to ensure against regressions.
Have you ran tests against this code?
This PR contains zero code changes.
Description of the Change
Still a draft...