Skip to content

Conversation

@jovanbulck
Copy link
Contributor

@jovanbulck jovanbulck commented Nov 28, 2024

Add the following features:

Possible further improvements:

  • only show the "open in PhotoSphere" button for pictures that we labeled as "panoramas"?
  • parse the XMP metadata to discover actual photospheres, even if they are < 3:1? This is what the files/photosphere NC app seems to do. In principle, this could be done server side and cached in the oc_memories table, but not all panorama pictures include XMP data afaik.

image
image


public function transformPanoFilter(IQueryBuilder &$query, bool $aggregate): void
{
$query->andWhere('m.w >= '.PANOROMA_ASPECT_RATIO.' * m.h');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these will scan the entire table - these need the right indexes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this expression can't be optimized with index too, probably needs a separate boolean field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback, makes sense! If I find some time later, I'll try to add a pano boolean field in the oc_memories table

@baka0815
Copy link

@jovanbulck are you still working on this? Is there anything you need help with?
I would love to see this feature in Memories.

@jovanbulck
Copy link
Contributor Author

@jovanbulck are you still working on this? Is there anything you need help with? I would love to see this feature in Memories.

I'm sorry, but I'm not working on this anymore (switched to a different photo management system). Though you're very welcome to fork my fork and continue development as you see fit!

@baka0815
Copy link

baka0815 commented Sep 2, 2025

I got it working on my side and might take over your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration with Photosphere viewer Photo Sphere Viewer Panorama Sidebar Menu

3 participants