Skip to content

Regenerate components.d.ts for Stencil 4.43.2 - #17956

Merged
cnunciato merged 1 commit into
masterfrom
cnunciato/regen-components-dts
Mar 13, 2026
Merged

Regenerate components.d.ts for Stencil 4.43.2#17956
cnunciato merged 1 commit into
masterfrom
cnunciato/regen-components-dts

Conversation

@cnunciato

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Verified the regenerated file matches what Stencil 4.43.2 produces on a clean build
  • CI passes

🤖 Generated with Claude Code

Dependabot PR #17748 bumped @stencil/core from 4.41.2 to 4.43.2 but
did not regenerate this file. Any local build produces a dirty diff
because Stencil 4.43.2 emits a different codegen format (new
*Attributes interfaces and Omit-based IntrinsicElements mappings).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude

claude Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Docs Review — PR #17956

Scope: theme/stencil/src/components.d.ts (auto-generated file)

Summary

This PR regenerates components.d.ts to match the codegen output of @stencil/core 4.43.2 (bumped in Dependabot PR #17748). The changes are entirely within a machine-generated TypeScript declaration file.

Changes observed

The diff reflects Stencil 4.43.2's new codegen pattern for LocalJSX.IntrinsicElements and the @stencil/core module augmentation:

  1. New *Attributes interfaces — Stencil now emits a separate *Attributes interface for each component (e.g., CopilotSidebarAttributes, PulumiBannerAttributes), listing props with their attribute-level types.

  2. Updated IntrinsicElements entries — Instead of simple ComponentName references, entries now use a more granular mapped type pattern (Omit<...> & { [K in ...] }) that distinguishes between prop access (prop:) and attribute access (attr:). Components without props (e.g., pulumi-example, pulumi-examples, pulumi-root) are left unchanged.

  3. Updated @stencil/core module augmentation — References changed from LocalJSX.ComponentName to LocalJSX.IntrinsicElements["component-name"], reusing the new mapped types from the LocalJSX namespace.

Review findings

No issues found. This is a straightforward regeneration of a machine-generated file. The changes are consistent with the Stencil 4.43.2 codegen format and align with the PR description.

Flag for human review (dependency/infrastructure): This is a follow-up to a Dependabot bump of @stencil/core (a runtime dependency). While the type declarations themselves are low risk, the underlying Stencil version change (4.41.2 -> 4.43.2) affects component compilation and runtime behavior. Confirm that the site builds and renders correctly with the new Stencil version — the type changes suggest Stencil has changed how it handles prop/attribute bindings, which could affect component hydration or SSR if applicable.


Mention @claude if you'd like additional reviews or fixes.

@CamSoper
CamSoper self-requested a review March 13, 2026 00:39
@cnunciato
cnunciato enabled auto-merge (squash) March 13, 2026 00:43
@pulumi-bot

Copy link
Copy Markdown
Collaborator

@cnunciato
cnunciato merged commit 6a386a6 into master Mar 13, 2026
13 checks passed
@cnunciato
cnunciato deleted the cnunciato/regen-components-dts branch March 13, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants