Skip to content

Fixed instruction providing two options where is just the same one - #21068

Merged
CamSoper merged 2 commits into
masterfrom
tehsis-patch-1
Aug 24, 2026
Merged

Fixed instruction providing two options where is just the same one#21068
CamSoper merged 2 commits into
masterfrom
tehsis-patch-1

Conversation

@tehsis

@tehsis tehsis commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Removed duplicated option. I guess this is a remanet from when esc was its own command.

@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:docs PR touches technical docs and removed review:triaging Claude Triage is currently classifying the PR labels Aug 22, 2026

@unblocked unblocked Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been reviewed by Unblocked Code Review

Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.

✅ No issues found

About Unblocked

📖 Documentation — Learn more in our docs.

💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.

👍 Give feedback — React to comments with 👍 or 👎 to help us improve.

⚙️ Customize — Adjust settings in your preferences.

@github-actions github-actions Bot added the review:in-progress Claude review is currently running label Aug 22, 2026
@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Pre-merge Review — Last updated 2026-08-24T18:18:13Z

Tip

Summary: A one-line docs fix to the ESC AWS OIDC guide (content/docs/esc/guides/configuring-oidc/aws.md): the validation step offered "either of the following" and then listed two bullets containing the identical pulumi env open command, differing only in which page they linked to. Collapsing them to a single sentence is correct and removes a genuine reader stumble; the surviving link (/docs/iac/cli/commands/pulumi_env_open/) is the right one of the two. The sole finding from the previous review — the merged sentence had inherited the bullet's grammar, dropping the article before command and the terminating period — was fixed at @CamSoper's request in e071577; the line now reads as a complete sentence and nothing remains outstanding. Passes run: fact-check on the pulumi env open command syntax (verified against the generated CLI reference), a frontmatter sweep, and a cross-sibling read of the five other configuring-oidc/* guides. Worth flagging outside the buckets (no line anchor in the changed file): the exact same duplicated-bullet bug is still present in 12 sibling pagesconfiguring-oidc/{gcp,azure,vault,infisical,doppler}.md and seven providers/{secrets,rotators}/*.md pages. This PR is right; a follow-up sweeping the same fix across those files would be a real win.

Review confidence:

Dimension Level Notes
mechanics HIGH
facts HIGH
cross-sibling consistency HIGH All five configuring-oidc/* siblings read; the duplicate persists in them (pre-existing, not introduced here).
Investigation log
  • Cross-sibling reads: 5 of 5 siblings
  • External claim verification: 1 of 1 claims verified (0 unverifiable, 0 contradicted) · 4 specialists (numerical, cross-reference, capability, framing); 0 cross-specialist corroborations · routed: 0 inline, 1 Pass 1, 0 Pass 2, 0 Pass 3.
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: ran on body + meta_desc
  • Temporal-trigger sweep: ran (recency words present in diff; spot-check in-review)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 1

🔍 Verification trail

2 claims extracted · 2 verified · 0 unverifiable · 0 contradicted
  • L109 in content/docs/esc/guides/configuring-oidc/aws.md "Users can validate that their Pulumi ESC OIDC configuration is working by running the pulumi env open <your-org>/<your-project>/<your-environment> command…" → ✅ verified (evidence: The auto-generated CLI reference confirms the command syntax: "pulumi env open [/][/][@] [property path] [flags]" — matching the claim's usage of pulumi env open; source: repo:content/docs/iac/cli/commands/pulumi_env_open.md)
  • L109 in content/docs/esc/guides/configuring-oidc/aws.md "…by running the pulumi env open … command of the Pulumi CLI." reads as a grammatical sentence → ✅ verified (evidence: previously ⚔️ mismatch — the rewrite had folded the former bullet fragment into a sentence without the article before command and without a terminating period. e071577 restored both; the line now reads "by running the `pulumi env open …` command of the Pulumi CLI." ; source: repo:content/docs/esc/guides/configuring-oidc/aws.md:109, repo:STYLE-GUIDE.md)

🚨 Outstanding in this PR

No outstanding findings.

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

  • [L109] content/docs/esc/guides/configuring-oidc/aws.md — merged sentence was missing the article before command and its terminating period (resolved in e071577). The line now reads: "You can validate that your configuration is working by running the pulumi env open <your-org>/<your-project>/<your-environment> command of the Pulumi CLI."

📜 Review history

  • 2026-08-22T02:16:22Z — De-duplicated validation step is a correct fix; flagged one grammar slip (missing article + period) in the merged sentence, and noted the same duplicate bug survives in 12 sibling pages. (317040b)
  • 2026-08-24T18:18:13Z — re-reviewed after fix push (1 new commit, e071577). @CamSoper asked for the outstanding finding to be corrected; applied the suggested rewrite on L109 and pushed it to tehsis-patch-1. Re-verified against the new diff: the finding is resolved, no regression introduced, and the sweep for other occurrences of the quoted phrase in the changed file found none. Nothing outstanding remains.

  • Refresh this review — comment @claude #update-review. Say what you fixed, or which finding you dispute and why; both work in the same mention.
  • Ask for anything else — comment @claude with no hashtag (questions, one-off fixes). Leaves this review untouched.

Important

Please don't hide, resolve, or delete this comment! It breaks things!

📖 How pre-merge review works — the full lifecycle, short-circuits, and escape hatches.

@github-actions github-actions Bot added review:outstanding-issues Claude review completed; outstanding has author-actionable findings and removed review:in-progress Claude review is currently running labels Aug 22, 2026
@pulumi-bot

pulumi-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

@CamSoper

Copy link
Copy Markdown
Contributor

@claude correct the outstanding issue and #update-review

@github-actions github-actions Bot added review:in-progress Claude review is currently running and removed review:outstanding-issues Claude review completed; outstanding has author-actionable findings labels Aug 24, 2026
Addresses the outstanding pre-merge review finding on L109: collapsing the
two duplicate bullets into a sentence left the bullet's grammar behind.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Review updated on @CamSoper's request.

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Aug 24, 2026
@CamSoper
CamSoper enabled auto-merge (squash) August 24, 2026 20:13
@CamSoper
CamSoper merged commit ca7c466 into master Aug 24, 2026
13 checks passed
@CamSoper
CamSoper deleted the tehsis-patch-1 branch August 24, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:docs PR touches technical docs review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants