Fix 8 compile-grade TypeScript/Go code snippet defects in content/docs - #21076
Conversation
Pre-merge Review — Last updated 2026-08-23T14:26:37ZTip Summary: This is a mechanical correctness PR across five existing docs pages ( Review confidence:
Investigation log
🔍 Verification trail3 claims extracted · 2 verified · 0 unverifiable · 0 contradicted
🚨 Outstanding in this PRNo outstanding findings in this PR.
|
|
Your site preview for commit e7823c4 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-21076-e7823c40.s3-website.us-west-2.amazonaws.com Changed pages: |
|
Read this by hand. Looks good. Merging. |
Summary
Fixes 8 compile-grade TypeScript/Go code snippet defects found by a real-compiler sweep of
content/docs/**(excluding auto-generated CLI reference pages and trees already covered by in-flight PR #21022 and PR #21074). Every fix below was verified two ways: the broken snippet fails the real tool (tsc --noEmitfor TS/JS,gofmt -efor Go), and the fixed snippet passes clean.TypeScript / JavaScript
content/docs/iac/guides/clouds/aws/lambda.md:391— added the missing closing parenthesis for the outeronObjectCreated(call (});→}));).content/docs/iac/guides/clouds/aws/lambda.md:581— added the missingconstkeyword (export docsBucketName = ...→export const docsBucketName = ...).content/docs/iac/concepts/functions/function-serialization.md:164— added the missing comma between two object method shorthand definitions.content/docs/iac/concepts/functions/function-serialization.md:176— same missing-comma fix, second occurrence.Go
content/docs/iac/guides/migration/migrating-to-pulumi/from-cloudformation.md— closed an unterminated backtick-delimited raw string literal holding a JSON template.content/docs/iac/guides/migration/migrating-to-pulumi/from-cloudformation.md— removed a stray extra}in a call's closing syntax.content/docs/idp/guides/publishing-from-github-actions.md(3 occurrences) — fixederr: =(a stray space splitting the short variable declaration token) to the correcterr :=.content/docs/idp/concepts/private-registry.md— escaped unescaped double quotes inside a Go string literal.Verification
tsc --noEmit(with wildcard ambient module stubs for@pulumi/*/@aws-sdk/*) against the fixed TypeScript/JavaScript snippets: zeroTS1xxxdiagnostics remain on the lines touched.gofmt -eagainst the fixed Go snippets: all parse clean.node ./scripts/lint/lint-markdown.json the 5 changed files: 0 errors../scripts/prettier.sh --checkon the 5 changed files: all pass.Fixes #21075
🧠 This PR was created by workprentice.