Add missing AWS regions to the Region enum - #6613
Conversation
Syncs `provider/types.go` with the region list in aws-sdk-go-base v2.0.0-beta.73, the version pinned in provider/go.mod. Five regions were missing: ap-southeast-6 Asia Pacific (New Zealand) aws eusc-de-east-1 AWS European Sovereign Cloud (DE) aws-eusc us-isob-west-1 US ISOB West aws-iso-b us-isof-east-1 US ISOF East aws-iso-f us-isof-south-1 US ISOF South aws-iso-f This adds two partition groups the enum did not previously cover, aws-eusc and aws-iso-f. The Region enum is a schema-level convenience type; listing a region does not by itself grant access. The ISO/ISOF and EUSC partitions require their own credentials and endpoint configuration, as is already the case for the us-iso-* and eu-isoe-west-1 entries. Fixes #6208 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
Does the PR have any schema changes?Generated by schema-tools v0.8.1. Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6613 +/- ##
=======================================
Coverage 15.85% 15.85%
=======================================
Files 376 376
Lines 92842 92842
=======================================
Hits 14724 14724
Misses 78096 78096
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This PR has been shipped in release v7.43.0. |
3 participants
Motivation
provider/types.gocarries a hand-maintainedRegionenum that is meant to stay in sync with the region list inaws-sdk-go-base. It had drifted: five regions were missing.#6208 asked for
ap-southeast-6. While confirming it, I diffed the whole enum againstaws-sdk-go-base v2.0.0-beta.73— the version pinned inprovider/go.mod— and found four more gaps.ap-southeast-6awseusc-de-east-1aws-euscus-isob-west-1aws-iso-bus-isof-east-1aws-iso-fus-isof-south-1aws-iso-fThis also adds two partition groups the enum did not previously cover at all:
aws-euscandaws-iso-f.Note that #6208's title says
ap-southeast-6is "Asia Pacific - Malaysia" — that'sap-southeast-5.ap-southeast-6is Auckland, New Zealand, as a commenter on the issue points out, and that's the name used here.Verification
A throwaway test walked every value in the enum and asserted that both
endpoints.PartitionForRegionand upstream'snames.PartitionForRegionresolve it to the same partition. All 46 pass, including the five new ones:The enum is now exactly the upstream set — no missing regions, no extras, no duplicate value or name.
Scope
The
Regionenum is a schema-level convenience type; listing a region does not by itself grant access. The ISO/ISOF and EUSC partitions need their own credentials and endpoint configuration — already true of theus-iso-*andeu-isoe-west-1entries this enum has carried for a while, so nothing new is implied.Adding enum values is additive and non-breaking in every SDK language.
Related
#4406 tracks generating this enum automatically rather than maintaining it by hand. This PR is exactly the toil that issue describes, so it stays open.
Fixes #6208