Upgrade #2842
Merged
Upgrade #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to see what's changed in the version selection when schema generation starts to fail.
Migrate.AssessmentOperation references the type VmUptimeResponse already defined by a previous API version, but which changes a property hoursPerDay from being a number to an integer which is a breaking change.
Does the PR have any schema changes?Looking good! No breaking changes found. |
thomas11
reviewed
Oct 23, 2023
thomas11
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2839
The
Migrate.VmUptimeArgstype is incompatible between 2019-10-01 and 2023-03-15 as the propertyHoursPerDaychanged from a number to an integer, which is a breaking change. To avoid this, we exclude pulling the newAssessmentOperationresource into the default version.To investigate the issue, I edited the flow so we still return and output the calculated versions on a failure so we can see what new resources are being added at what version.