Skip to content

Add context timeout handling to prevent orphaned resources during delete operations #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rquitales wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add context timeout handling to prevent orphaned resources during delete operations #3131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions provider/pkg/provider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1428,6 +1428,13 @@ func (k *azureNativeProvider) Delete(ctx context.Context, req *rpc.DeleteRequest
return nil, azure.AzureError(err)
}
}

// Check if we timed out and the resource still exists. If so, return an error.
// This is a best-effort check, as the resource may have been deleted after the timeout.
if err := ctx.Err(); err != nil && errors.Is(err, context.DeadlineExceeded) {
return nil, fmt.Errorf("timed out waiting for resource %q to be deleted", id)
}

return &pbempty.Empty{}, nil
}

Expand Down