Preserve spec-form aliases on components - #581
Conversation
Fixes #543. pulumi-go-provider v1.6.0 (pulumi/pulumi-go-provider#574) changes ConstructRequest.Aliases from []resource.URN to []resource.Alias, so spec-form aliases (name, type, project, stack, parent, noParent) are no longer silently dropped before they reach the language host. Forward the full alias on the component's own registration by replacing aliasURNsToProto with aliasesToProto, mirroring the run-side conversion in server.go. No child-alias propagation is needed: once the component itself matches its old resource via the alias, the engine's step generator multiplies parent aliases onto children (generateAliases/inheritedChildAlias), so the component's children are preserved as well. Un-parks the provider-alias-component conformance test, which passes both runs.
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found.
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
| time: 2026-08-25T10:17:19Z | ||
| custom: | ||
| Component: runtime | ||
| PR: "543" |
There was a problem hiding this comment.
The PR field should be the GitHub PR number that ships the change (581), not the issue number (543).
| PR: "543" | |
| PR: "581" |
Based on CONTRIBUTING.md
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #581 +/- ##
==========================================
+ Coverage 79.29% 79.31% +0.01%
==========================================
Files 93 93
Lines 19502 19514 +12
==========================================
+ Hits 15465 15478 +13
+ Misses 2817 2815 -2
- Partials 1220 1221 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Fixes #543.
pulumi-go-provider v1.6.0 (pulumi/pulumi-go-provider#574) changes
ConstructRequest.Aliasesfrom[]resource.URNto[]resource.Alias, so spec-form aliases (name, type, project, stack, parent,noParent) are no longer silently dropped before they reach the language host. This PR upgrades to v1.6.0 and forwards the full alias on the component's own registration by replacingaliasURNsToProtowithaliasesToProto, mirroring the run-side conversion inserver.go.No child-alias propagation is needed: once the component itself matches its old resource via the alias, the engine's step generator multiplies parent aliases onto children (
generateAliases/inheritedChildAlias), so the component's children are preserved as well.Un-parks the
provider-alias-componentconformance test, which passes both runs.