Tests for #1280 - #1283
Closed
guineveresaenger wants to merge 6 commits into
Closed
Conversation
Adds a `serviceTemplate` field to the Workspace spec so users can set custom annotations and labels on the headless Service that fronts a workspace's pods. Because `StackSpec.WorkspaceTemplate` is a Workspace apply configuration, the field is settable from a Stack via `spec.workspaceTemplate.spec.serviceTemplate.metadata` with no new Stack-side plumbing. System labels win over conflicting template labels and the Service selector is kept to the system labels only, so pod routing is never affected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Use apimachinery labels.Merge instead of a custom mergeStringMaps helper - Match the field name in the EmbeddedServiceTemplateSpec.Metadata comment - Drop the redundant per-label loop and selector assertion in the test - Regenerate Workspace CRD/docs for the updated field comment Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…to service-template-annotations
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1283 +/- ##
==========================================
+ Coverage 55.95% 56.56% +0.61%
==========================================
Files 34 35 +1
Lines 4130 4506 +376
==========================================
+ Hits 2311 2549 +238
- Misses 1594 1720 +126
- Partials 225 237 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No blocking issues found. serviceTemplate plumbing verified end-to-end (Stack strategic-merge → Workspace SSA → newService), label-merge precedence is correct (system labels win, selector unaffected), and the new behavior is covered by TestNewService. Leaving as COMMENT for maintainer sign-off since this adds a new public CRD API field.
Reviewed by Internal Trusted PR Reviewer
Add this agentic workflows to your repo
To install this agentic workflow, run
gh aw add pulumi-labs/gh-aw-internal/.github/workflows/gh-aw-pr-review.md@fccb0509de811cdc59bfe4e77504af0d4b5ebaa1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for #1280