Disable slack notification for failed minio test - #153
Merged
Conversation
Member
|
Why disable this? Is this dead code? |
Member
Author
|
It currently spams the channel every time a test fails in a PR. It looks like the original intent was to run the minio test as part of the pulumi-service container release, but that integration hasn't run in 6+ months, so I figured it was safe to disable. |
Contributor
rshade
force-pushed
the
lblackstone/minio-slack
branch
2 times, most recently
from
June 30, 2025 16:35
afeffb8 to
baa56b6
Compare
rshade
force-pushed
the
lblackstone/minio-slack
branch
from
August 4, 2025 21:43
baa56b6 to
d462864
Compare
rshade
enabled auto-merge (squash)
August 5, 2025 18:26
rshade
force-pushed
the
lblackstone/minio-slack
branch
from
August 5, 2025 18:26
d462864 to
02bcf8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the
.github/workflows/test-with-minio.ymlfile by removing the Slack notification step for failed Minio integration tests. This change reduces external dependencies and simplifies the workflow configuration.Workflow changes:
.github/workflows/test-with-minio.yml: Removed theNotify Slackstep, which used the8398a7/action-slackaction to send failure notifications to Slack.