Automated Pulumi/Pulumi upgrade - #3587
Conversation
Review Verdict: ApprovedMechanical, forward-only dependency bump (pulumi/pulumi v3.256.0 -> v3.259.0 plus transitive deps) touching only go.mod/go.sum; verified no version downgrades, go build/vet/mod verify succeed, and the change reproduces byte-identical from View session · Was this review helpful? Yes · No |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3587 +/- ##
=======================================
Coverage 70.47% 70.47%
=======================================
Files 358 358
Lines 39474 39474
=======================================
Hits 27820 27820
Misses 9705 9705
Partials 1949 1949 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Reviewed this automated dependency bump, which touches only go.mod/go.sum in the root module and tools/. It raises github.com/pulumi/pulumi/pkg/v3 and github.com/pulumi/pulumi/sdk/v3 from v3.256.0 to v3.259.0 in lockstep, plus a large set of transitive dependency updates (AWS SDK v2, Google Cloud, OpenTelemetry, golang.org/x/*, etc). No .go source files change.
Verification performed (independently, and corroborated by four specialist passes covering correctness, security, AGENTS.md compliance, and tests):
- Diffed every changed module version across both
go.modfiles: every bump moves strictly forward, no accidental downgrades. go build ./...andgo vet ./...succeed against the new dependency graph in both the root module andtools/.go mod verifypasses for both modules; reproducinggo mod tidylocally yields a byte-identicalgo.mod/go.sum, confirming this matches the repo'smake tidyconvention (AGENTS.md).go.work/go.work.sumare correctly absent (gitignored, per.gitignore), so no workspace-refresh omission.- New transitive-only dependencies pulled in by the SDK bump (e.g. keyring/TPM-related packages) are not reachable from this bridge's code paths, so they don't introduce new attack surface here.
CI: the one required check from the branch ruleset ("Ensure test assets build cleanly") is green. The full Test and Lint matrix is still finishing; one shard (test (1.26.x, ubuntu-latest, DEFAULT, 0)) shows a failure, but its log shows it failed within 6 seconds on a fetch failed error while authenticating to the pulumi/esc-action secrets step, before any test code ran — an infrastructure flake unrelated to this diff, not a required check, and not evidence of a regression from the dependency bump.
No issues found across any of the four specialist passes (correctness, security, tests, AGENTS.md compliance).
No description provided.