make sure facts for windows server 2025 is discovered as 2025

[brajjan]

Windows Server 2025 was released 2024-11-01 and the current facts discovers 2025-servers as 11 instead of 2025

This PR makes sure that 2025 server operating systems resolve to 2025 instead of 11

Manually tested on a Windows server 2025 server and Windows 11 client

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[joshcooper]

Thanks @brajjan! Do you know of documentation from Microsoft where they specify the relationship between build numbers and 2025?

[brajjan]

Sure. This is the official documentation of all LTSC releases. https://learn.microsoft.com/en-us/windows-server/get-started/windows-server-release-info

The build number should be the same for 2025 LTSC and only the revision that changes when updates are released.

Dont know of any lists where all versions are listed together, but this might help. https://learn.microsoft.com/en-us/windows/release-health/

[joshcooper]

Looks like a valid spec failure for Windows 10 detection? https://github.com/puppetlabs/facter/actions/runs/11720779220/job/32817170282?pr=2778#step:4:14

[brajjan]

It sure does.. was no check for version number for Windows 10 before my PR - only checking if it was a client less than version 11

Seems like some of the version checks in the code are against the LTSC/GA-releases and some checks are for Insiders/beta-releases.
2019-Build 17623 - Insiders (LTSC = 17763)
2022-Build 20348 - LTSC

What do you think is the proper way to do this? Check the first beta release of each version and have that as the check, or is it acceptable to only check for GA/LTSC-releases? If acceptable I will update all version checks to check for the earliest GA/LTSC-release for that OS

I can probably get a hold of all beta build numbers if I do a bit of research.

[dhs-rec]

While testing Puppet on Windows Server 2025 in AWS, I made the same change to get the correct release information, only to find this PR afterwards. Would be great to have it in the next Puppet 7/8 releases.

[brajjan]

@joshcooper Can this be merged?