-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/puppet ca v1 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive support for the Puppet Certificate Authority (CA) V1 API, enabling management of SSL certificates, certificate signing requests (CSRs), certificate revocation lists (CRLs), and related certificate authority operations.
Key Changes
- Implements the main
PuppetCAV1resource class with endpoints for retrieving certificates, checking expirations, and cleaning certificates - Adds four sub-resource classes:
CertificateRequest,CertificateStatus,CertificateRevocationList, andBulkCertificateSign - Removes
.freezefrom hash constants in existing code (apparent convention change)
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/pe_client/resources/puppet_ca.v1.rb | Main Puppet CA V1 API resource with certificate operations and sub-resource accessors |
| lib/pe_client/resources/puppet_ca.v1/certificate_status.rb | Certificate status management (get, list, update, delete) |
| lib/pe_client/resources/puppet_ca.v1/certificate_request.rb | CSR operations (get, submit, delete) |
| lib/pe_client/resources/puppet_ca.v1/certificate_revocation_list.rb | CRL retrieval and updates |
| lib/pe_client/resources/puppet_ca.v1/bulk_certificate_sign.rb | Bulk certificate signing operations |
| spec/pe_client/resources/puppet_ca_v1_spec.rb | Tests for main PuppetCAV1 resource |
| spec/pe_client/resources/puppet_ca.v1/certificate_status_spec.rb | Tests for certificate status operations |
| spec/pe_client/resources/puppet_ca.v1/certificate_request_spec.rb | Tests for CSR operations |
| spec/pe_client/resources/puppet_ca.v1/certificate_revocation_list_spec.rb | Tests for CRL operations |
| spec/pe_client/resources/puppet_ca.v1/bulk_certificate_sign_spec.rb | Tests for bulk signing operations |
| sig/pe_client/resource/puppet_ca.v1.rbs | Type signatures for main PuppetCAV1 resource |
| sig/pe_client/resource/puppet_ca.v1/certificate_status.rbs | Type signatures for certificate status |
| sig/pe_client/resource/puppet_ca.v1/certificate_request.rbs | Type signatures for certificate request |
| sig/pe_client/resource/puppet_ca.v1/certificate_revocation_list.rbs | Type signatures for CRL |
| sig/pe_client/resource/puppet_ca.v1/bulk_certificate_sign.rbs | Type signatures for bulk signing |
| lib/pe_client/resources/puppet.v3/file_bucket.rb | Removes .freeze from HEADERS constant |
| lib/pe_client/resources/puppet.v3.rb | Removes .freeze from inline hash |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.